Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(datahub-client): improve Avro schema conversions #12141

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
+1,743 −1,058
Open

feat(datahub-client): improve Avro schema conversions #12141

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
0b80492
feat(datahub-client): improve Avro schema conversions
sgomezvillamor Dec 16, 2024
b91a1ec
native data type mentions actual type in case of nullalbe unions
sgomezvillamor Dec 17, 2024
5b1bbdf
field path improvements for nested fields and some other improvements
sgomezvillamor Jan 9, 2025
42aff3b
keep previous (v2) behaviour for unions
sgomezvillamor Jan 10, 2025
26caf99
avro_schema_util first version (avro schema is dict)
sgomezvillamor Feb 7, 2025
2346fa5
using avro.schema classes + passing tests
sgomezvillamor Feb 12, 2025
392a1e8
remove legacy schema_util.py and update avro schema converter callers
sgomezvillamor Feb 12, 2025
1de9da8
fixing tests
sgomezvillamor Feb 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion metadata-ingestion/scripts/modeldocgen.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
from datahub.emitter.rest_emitter import DatahubRestEmitter
from datahub.ingestion.api.common import PipelineContext, RecordEnvelope
from datahub.ingestion.api.sink import NoopWriteCallback
from datahub.ingestion.extractor.schema_util import avro_schema_to_mce_fields
from datahub.ingestion.extractor.avro_schema_util import avro_schema_to_mce_fields
from datahub.ingestion.sink.file import FileSink, FileSinkConfig
from datahub.metadata.schema_classes import (
BrowsePathEntryClass,
Expand Down
2 changes: 1 addition & 1 deletion metadata-ingestion/src/datahub/api/entities/dataset/dataset.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
validate_ownership_type,
)
from datahub.emitter.mcp import MetadataChangeProposalWrapper
from datahub.ingestion.extractor.schema_util import avro_schema_to_mce_fields
from datahub.ingestion.extractor.avro_schema_util import avro_schema_to_mce_fields
from datahub.ingestion.graph.client import DataHubGraph
from datahub.metadata.schema_classes import (
AuditStampClass,
Expand Down
Loading