Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): add container CLI to apply patches for tag, term, owner #12418

Merged
merged 5 commits into from
Jan 22, 2025

Conversation

anshbansal
Copy link
Collaborator

@anshbansal anshbansal commented Jan 21, 2025

Allows to use

datahub container tag --container-urn "urn:li:container:0e9e46bd6d5cf645f33d5a8f0254bc2d" --tag-urn urn:li:tag:tag1

to add patch this tag recursively on all datasets.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@anshbansal anshbansal marked this pull request as draft January 21, 2025 16:04
@anshbansal anshbansal marked this pull request as ready for review January 21, 2025 16:07
@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Jan 21, 2025
@datahub-cyborg datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label Jan 21, 2025
Copy link

codecov bot commented Jan 21, 2025

Codecov Report

Attention: Patch coverage is 55.81395% with 19 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...etadata-ingestion/src/datahub/cli/container_cli.py 53.65% 19 Missing ⚠️
Files with missing lines Coverage Δ
metadata-ingestion/src/datahub/entrypoints.py 69.69% <100.00%> (+0.46%) ⬆️
...etadata-ingestion/src/datahub/cli/container_cli.py 53.65% <53.65%> (ø)

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96758e2...72450db. Read the comment docs.

@datahub-cyborg datahub-cyborg bot added pending-submitter-response Issue/request has been reviewed but requires a response from the submitter and removed needs-review Label for PRs that need review from a maintainer. labels Jan 21, 2025
Copy link
Contributor

@sgomezvillamor sgomezvillamor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
We may also add some validation on the input URNs (container and tag|term|owner), even if this is later validated in backend too.

@anshbansal anshbansal merged commit b75d3ed into master Jan 22, 2025
189 of 192 checks passed
@anshbansal anshbansal deleted the ab-2025-jan-21-add-helper branch January 22, 2025 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ingestion PR or Issue related to the ingestion of metadata pending-submitter-merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants