Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli): ignore prereleases when suggesting upgrades #12424

Merged
merged 1 commit into from
Jan 24, 2025
Merged

fix(cli): ignore prereleases when suggesting upgrades #12424

merged 1 commit into from
Jan 24, 2025

Conversation

hsheth2
Copy link
Collaborator

@hsheth2 hsheth2 commented Jan 21, 2025

By fetching the "latest" release, we can ignore prereleases and fetch less data.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@hsheth2
fix(cli): ignore prereleases when suggesting upgrades
7627ebc 
By fetching the "latest" release, we can ignore prereleases and fetch
less data.
@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Jan 21, 2025
@codecov Codecov
Copy link

codecov bot commented Jan 21, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Files with missing lines Coverage Δ
metadata-ingestion/src/datahub/upgrade/upgrade.py 62.10% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 995857c...7627ebc. Read the comment docs.

@datahub-cyborg datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label Jan 22, 2025
sgomezvillamor
sgomezvillamor approved these changes Jan 24, 2025
View reviewed changes
Copy link
Contributor

@sgomezvillamor sgomezvillamor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@datahub-cyborg datahub-cyborg bot added pending-submitter-merge and removed needs-review Label for PRs that need review from a maintainer. labels Jan 24, 2025
@anshbansal anshbansal merged commit f80d58d into master Jan 24, 2025
222 of 249 checks passed
@anshbansal anshbansal deleted the skip-prereleases-in-upgrade branch January 24, 2025 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgomezvillamor sgomezvillamor sgomezvillamor approved these changes

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata pending-submitter-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hsheth2 @sgomezvillamor @anshbansal