fix(ingest): fix reporting for missing secure view lineage #12430
+77
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Secure Views in databases created from Snowflake Shares will always be missing on view definitions and that need not be reported as warning. We would report such views as info in pipeline run.
github-actions
bot
added
the
ingestion
datahub-cyborg
bot
added
the
needs-review
Codecov ReportAll modified and coverable lines are covered by tests ✅
... and 9 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
hsheth2
approved these changes
Jan 23, 2025
| except KeyError: | ||
| # Received secure view definitions but the view is not present in results | ||
| self.structured_reporter.info( | ||
| "Secure view definition not found. Lineage will be missing for the view.", |
There was a problem hiding this comment.
in general, let's always set both title and message for structured logs
otherwise the default title is "An unexpected issue occurred" which isn't great
metadata-ingestion/src/datahub/ingestion/source/snowflake/snowflake_schema_gen.py
Outdated
Show resolved
Hide resolved
datahub-cyborg
bot
added
pending-submitter-merge
and removed
needs-review
…flake_schema_gen.py Co-authored-by: Harshal Sheth <[email protected]>
eagle-25
pushed a commit
to eagle-25/datahub
that referenced
this pull request
Feb 12, 2025
…roject#12430) Co-authored-by: Harshal Sheth <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Secure Views in databases created from Snowflake Shares will always be missing on view definitions and that need not be reported as warning. We would report such views as info in pipeline run.
Checklist