feat(snowflake): set is_temp_table and is_allowed_table function for SqlParsingAggregator in SnowflakeV2Source

[sgomezvillamor]

Checklist

• The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
• Links to related issues (if applicable)
• Tests for the changes have been added/updated (if applicable)
• Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
• For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

[codecov]

Codecov Report

Attention: Patch coverage is 78.57143% with 3 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
...datahub/ingestion/source/snowflake/snowflake_v2.py	78.57%	3 Missing ⚠️

Files with missing lines	Coverage Δ
...datahub/ingestion/source/snowflake/snowflake_v2.py	88.51% <78.57%> (-0.58%)	⬇️

... and 1 file with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 563656c...0dda7c5. Read the comment docs.

[hsheth2]

maybe note that this logic mirrors the logic from snowflake_queries.py?

not sure if there's a way to remove the code duplication, but that'd be even better

[sgomezvillamor]

This PR extends the existing note here
https://github.com/datahub-project/datahub/blob/master/metadata-ingestion/src/datahub/ingestion/source/snowflake/snowflake_v2.py#L545-L547
which is what causes the duplication

[sgomezvillamor]

The only thing that comes to my mind would be to give the responsibility of instantiating SqlParsingAggregator to the SnowflakeV2Source itself, so SnowflakeQueriesExtractor gets it as constructor parameter.
This way we still instantiate SqlParsingAggregator twice but is_temp_table and is_allowed_table would be defined once in the SnowflakeV2Source
WDYT?

[sgomezvillamor]

I spent some time trying this, and it's getting complicated, so I'm leaving it as is.