Merge pull request #1144 from ethho/fix-dev-container

PLAT-142: Fix dev container follow-up
datajoint · Jan 2, 2024 · 8035628 · 8035628
2 parents 90d1b5d + 43598c9
commit 8035628
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/.devcontainer/devcontainer.json b/.devcontainer/devcontainer.json
@@ -31,6 +31,7 @@
 	"onCreateCommand": "python3 -m pip install -e .",
 	"features": {
 		"ghcr.io/devcontainers/features/git:1": {},
+		"ghcr.io/devcontainers/features/docker-in-docker:2": {},
 	},
 	// Configure tool-specific properties.
 	"customizations": {

diff --git a/.devcontainer/docker-compose.yml b/.devcontainer/docker-compose.yml
@@ -6,13 +6,13 @@ services:
     # folder. Note that the path of the Dockerfile and context is relative to the *primary*
     # docker-compose.yml file (the first in the devcontainer.json "dockerComposeFile"
     # array). The sample below assumes your primary file is in the root of your project.
-    container_name: devcontainer
-    image: devcontainer
+    container_name: datajoint-python-devcontainer
+    image: datajoint/datajoint-python-devcontainer:${PY_VER:-3.11}-${DISTRO:-buster}
     build:
       context: .
       dockerfile: .devcontainer/Dockerfile
       args:
-        - PY_VER=${PY_VER:-3.8}
+        - PY_VER=${PY_VER:-3.11}
         - DISTRO=${DISTRO:-buster}
 
     volumes: