PLAT-160: Migrate test_privileges #1132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethho
commented
Dec 13, 2023
| @@ -52,12 +53,17 @@ def enable_filepath_feature(monkeypatch): | |||
|
|
|||
|
|
|||
| @pytest.fixture(scope="session") | |||
| def connection_root_bare(): | |||
| connection = dj.Connection( | |||
| def db_creds_root() -> Dict: | |||
There was a problem hiding this comment.
We need the value of os.getenv("DJ_HOST") in several test modules. Best to perform this once and inject it as a fixture. Making a note to replace the pattern os.getenv("DJ_HOST") with this fixture in other modules besides test_privileges.
There was a problem hiding this comment.
Another thing that we should move to fixtures during the "big clean up".
There was a problem hiding this comment.
Why can't we just import CONN_INFO (as done in #1133)
A-Baji
approved these changes
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dev-tests