Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pipeline declaration, ingestion script, and notebooks #18

Merged
merged 32 commits into from
Apr 29, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
32 commits
Select commit Hold shift + click to select a range
a09e53c
Fix format
kabilar Apr 23, 2022
8561af8
Add requirement
kabilar Apr 23, 2022
6285d87
Remove `tests/user_data`
kabilar Apr 24, 2022
9184e65
Remove previous notebook versions.
kabilar Apr 24, 2022
13108f7
Add jupytext paired script
kabilar Apr 24, 2022
c5df6b0
Update Compose file
kabilar Apr 24, 2022
0b99792
Update data download notebook
kabilar Apr 24, 2022
8645c5e
Update attribute name and import statement
kabilar Apr 24, 2022
0fe7b3c
Update workflow structure notebook
kabilar Apr 24, 2022
e5e5170
Update path handling
kabilar Apr 24, 2022
781e75d
Update database configuration notebook
kabilar Apr 24, 2022
c9ffda9
Update automated ingestion script
kabilar Apr 24, 2022
acee799
Update package version
kabilar Apr 24, 2022
849cd94
Add acquisition software to sessions csv
kabilar Apr 24, 2022
d05965f
Pin version number
kabilar Apr 24, 2022
ae40356
Add CaImAn installation
kabilar Apr 24, 2022
d054b16
Add specific json file name
kabilar Apr 24, 2022
99ceda4
Update image version
kabilar Apr 24, 2022
5e22ce1
Install CaImAn from `flatironinstitute` base repo
kabilar Apr 24, 2022
3a53849
Update Dockerfiles
kabilar Apr 25, 2022
74ed693
Revert import
kabilar Apr 25, 2022
b8f0c48
Update Docker files
kabilar Apr 26, 2022
db78117
Update paths
kabilar Apr 26, 2022
b286063
Add AnatomicalLocation table
kabilar Apr 26, 2022
dcdf9e9
Add diagram
kabilar Apr 26, 2022
ff6348c
Update 03-process notebook
kabilar Apr 26, 2022
2461b28
Update parameter list
kabilar Apr 26, 2022
c701411
Fix for multiple root data directories
kabilar Apr 27, 2022
6af3cff
Remove file list and sampling rate from params
kabilar Apr 27, 2022
899414b
Update equipment table to be generalizable
kabilar Apr 27, 2022
23b177d
Update diagram
kabilar Apr 27, 2022
268949f
Separate commands into individual cells
kabilar Apr 29, 2022
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,8 @@ DataJoint Elements ([element-lab](https://github.com/datajoint/element-lab),
[element-miniscope](https://github.com/datajoint/element-miniscope)) assembled
together to form a fully functional workflow.

![element miniscope diagram](images/attached_miniscope_element.svg)

## Installation instructions

+ The installation instructions can be found at the
Expand Down
11 changes: 5 additions & 6 deletions docker/Dockerfile.dev
Original file line number Diff line number Diff line change
@@ -1,18 +1,17 @@
FROM datajoint/djbase:py3.8-debian-fcd8909
FROM datajoint/djbase:py3.9-debian-8eb1715

USER anaconda:anaconda

COPY ./workflow-miniscope/docker/apt_requirements.txt /tmp/
RUN /entrypoint.sh echo "Installed dependencies."

# Install Caiman
RUN git clone --branch master https://github.com/datajoint-company/CaImAn
# Install CaImAn
RUN git clone --branch master https://github.com/kabilar/CaImAn
WORKDIR /main/CaImAn
RUN conda install -n base -c conda-forge -y mamba
RUN /bin/bash -c 'mamba env update --n base --file environment.yml'
# Suite2p requires np.__version__ == 1.21
RUN pip install numpy==1.21
RUN /bin/bash -c 'mamba env update --n base --file environment.yml'
RUN pip install .
RUN python caimanmanager.py install --inplace

WORKDIR /main

Expand Down
12 changes: 11 additions & 1 deletion docker/Dockerfile.test
Original file line number Diff line number Diff line change
@@ -1,10 +1,18 @@
FROM datajoint/djbase:py3.9-debian-fcd8909
FROM datajoint/djbase:py3.9-debian-8eb1715

USER anaconda:anaconda

COPY ./workflow-miniscope/docker/apt_requirements.txt /tmp/
RUN /entrypoint.sh echo "Installed dependencies."

# Install CaImAn
RUN git clone --branch master https://github.com/kabilar/CaImAn
WORKDIR /main/CaImAn
RUN conda install -n base -c conda-forge -y mamba
RUN /bin/bash -c 'mamba env update --n base --file environment.yml'
RUN pip install .
RUN python caimanmanager.py install --inplace

WORKDIR /main

# Option 1 - Install DataJoint's remote fork of the workflow and elements
Expand Down Expand Up @@ -45,4 +53,6 @@ RUN rm -f /main/workflow-miniscope/dj_local_conf.json
RUN pip install /main/workflow-miniscope
RUN pip install -r /main/workflow-miniscope/requirements_test.txt

RUN pip uninstall datajoint
RUN pip install git+
WORKDIR /main/workflow-miniscope
2 changes: 1 addition & 1 deletion docker/docker-compose-dev.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ services:
context: ../../
dockerfile: ./workflow-miniscope/docker/Dockerfile.dev
env_file: .env
image: workflow-miniscope-dev:0.1.0a2
image: workflow-miniscope-dev:0.1.0
container_name: workflow-miniscope-dev
environment:
- MINISCOPE_ROOT_DATA_DIR=/main/test_data/workflow_miniscope/
Expand Down
5 changes: 3 additions & 2 deletions docker/docker-compose-test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,8 @@ services:
build:
context: ../../
dockerfile: ./workflow-miniscope/docker/Dockerfile.test
image: workflow-miniscope-test:0.1.0a2
env_file: .env
image: workflow-miniscope-test:0.1.0
container_name: workflow-miniscope-test
environment:
- DJ_HOST=db
Expand All @@ -30,7 +31,7 @@ services:
- -c
- |
echo "------ INTEGRATION TESTS ------"
pytest -sv --cov-report term-missing --cov=workflow_miniscope -p no:warnings
pytest -sv --cov-report term-missing --cov=workflow_miniscope -p no:warnings tests/
tail -f /dev/null
volumes:
- ${TEST_DATA_DIR}:/main/test_data
Expand Down
Loading