Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow git to modify the mounted /app directory when employing docker-compose.read-only.local.override.yml #285

Merged
merged 2 commits into from
Jan 4, 2024

Conversation

candleindark
Copy link
Collaborator

The changes in this PR allows git to modify the mounted /app directory when employing docker-compose.read-only.local.override.yml. This is needed using Docker instead of Podman and the Docker service is not provided by a VM. A similar change is done to docker-compose.dev.local.override.yml in #279.

This PR is based on #284. To get the relevant change in this PR, the master branch should be merged into the associated branch after #284 is merged to the master branch.

This is needed using Docker instead of podman and
the Docker service is not provided by a VM
Copy link

codecov bot commented Jan 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (92b9f91) 98.75% compared to head (c44a79d) 98.75%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #285   +/-   ##
=======================================
  Coverage   98.75%   98.75%           
=======================================
  Files          48       48           
  Lines        2242     2242           
=======================================
  Hits         2214     2214           
  Misses         28       28           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@candleindark candleindark marked this pull request as ready for review January 4, 2024 19:04
@candleindark candleindark merged commit a01402c into datalad:master Jan 4, 2024
6 checks passed
@candleindark candleindark deleted the adjust-read-only-override branch January 4, 2024 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant