-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to SCSS #36
Draft
Leland
wants to merge
17
commits into
datamade:main
Choose a base branch
from
Leland:style-tweaks
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Migrate to SCSS #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a file that has become a de facto standard for IDEs to automatically know a project's preferred formatting
vendor folders makes it much clearer what comes from contributors and what is just tracked from external sources
Leland
force-pushed
the
style-tweaks
branch
3 times, most recently
from
December 27, 2023 05:59
ebb7a17
to
ec4c335
Compare
The scope of this grew a bit. I'll split out the Bootstrap SCSS work to its own PR. |
Browsed around for a while and the CSS was completely unused
The opening triple dashes are per Jekyll requirements: https://jekyllrb.com/docs/assets/
Leland
force-pushed
the
style-tweaks
branch
4 times, most recently
from
December 27, 2023 16:38
f1c0014
to
009e9d1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ultimately, this PR is about cleaning up some very old assets, moving to a modular SCSS approach, and thus clearing the way for far easier styling without needing to deeply override Bootstrap.
This also comes with other benefits, like not shipping unused Bootstrap features, and sourcemaps:
Major
Minor
.editorconfig
fileLICENSE
andREADME.md
from production siteWIP, more coming.