-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update default version to fix CVEs #392
base: master
Are you sure you want to change the base?
Conversation
@@ -77,7 +77,7 @@ const ( | |||
var imageLookupMap map[Image]string = map[Image]string{ | |||
|
|||
Cassandra_3_11_6: "datastax/cassandra-mgmtapi-3_11_6:v0.1.5", | |||
Cassandra_3_11_7: "datastax/cassandra-mgmtapi-3_11_7:v0.1.13", | |||
Cassandra_3_11_7: "datastax/cassandra-mgmtapi-3_11_7:v0.1.22", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @zencircle.
The v0.1.22
image is configured to run Cassandra as non-root whereas the v0.1.13
image is configured to run as root. While running as non-root is definitely a good change, switching the default image in this way probably merits some discussion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zencircle, John is right. You will likely run into problems with this bit of code:
https://github.com/zencircle/cass-operator/blob/patch-1/operator/pkg/images/images.go#L168-L179
as it will assume that the default 3.11.7 image is run as root. The version you are upgrading too does not run as root as John said.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zencircle
You likely have to remove "3.11.7" from this line:
https://github.com/zencircle/cass-operator/blob/patch-1/operator/pkg/images/images.go#L172
and change the line in the test that expects it to be run as root (from false to true) here:
https://github.com/zencircle/cass-operator/blob/patch-1/operator/pkg/images/images_test.go#L70
@zencircle You will also need to update the test here: |
@emerkle826 I fixed all the issues, now its failing on ecr credentials |
I'm not 100% sure, but I believe the ECR failure is because you do not have AWS credentials configured. This is likely only going to pass for PRs based on branches in the Also, there is some concern at the moment about changing the default Cassandra imaged used by cass-operator such that the process runs as the |
Workaround is to patch the datacenter,
|
@emerkle826 Can you progress on this one ? |
@zencircle We've actually moved this repo to k8ssandra/cass-operator. Version 1.7.0 of cass-operator was released (just minutes ago as I type this) and can be found here: Version 1.7.0 updates to Management API v0.1.25, which should have the updates you need. |
k8ssandra/management-api-for-apache-cassandra#83