Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[test]: basic test framework #5

Merged
merged 9 commits into from
May 10, 2024
Merged

[test]: basic test framework #5

merged 9 commits into from
May 10, 2024

Conversation

jordanrfrazier
Copy link

@jordanrfrazier jordanrfrazier commented May 8, 2024 •
edited
Loading

Adds some basic test framework + CI workflows.

nicoloboschi
nicoloboschi suggested changes May 8, 2024
View reviewed changes
Copy link

@nicoloboschi nicoloboschi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!
See my comments.

I think we should have a file describing each .json file what it represents and how the flow is done. Maybe a screenshot is ok too. (this is a langflow generic problem, let's try to think as users of it)

ragstack/pyproject.toml Show resolved Hide resolved
ragstack/pyproject.toml Outdated Show resolved Hide resolved
ragstack/pyproject.toml Outdated Show resolved Hide resolved
ragstack/tests/integration_tests/data/embedding.json Show resolved Hide resolved
ragstack/tests/integration_tests/test_astradb.py Show resolved Hide resolved
zzzming
zzzming approved these changes May 8, 2024
View reviewed changes
Copy link
Member

@zzzming zzzming left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If not in this PR or next PR, I think we should try to instantiate langflow from docker or docker-compose in CI.

@jordanrfrazier jordanrfrazier merged commit 1efa9ee into ragstack-main May 10, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zzzming zzzming zzzming approved these changes

@nicoloboschi nicoloboschi nicoloboschi requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jordanrfrazier @zzzming @nicoloboschi