Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix] 修复代理grafana 时不会生成配置文件的问题 #597

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

88fantasy
Copy link
Contributor

Purpose of the pull request

#371

Brief change log

no change

Verify this pull request

This pull request is code cleanup without any test coverage.

@FishingDanDan
Copy link

FishingDanDan commented Jan 23, 2025

兄弟,你提交的这个应该解决不了不生成配置文件的问题,我试了下不行。

  1. api启动的时候会从meta加载元数据信息到frame_service表,此时会维护了generator和config_map的关系,在grafana这个服务中,config_map是空的,因为没有parameter对的上。
  2. 配置集群-服务配置的时候会写入cluster_role_group_config表,此时会把generator和config_map的关系带过来到config_file_json字段上
  3. MasterServiceActor在下发安装服务命令的时候,会读cluster_role_group_config表
  4. ConfigServiceActor会通过genertor和config_map的对应关系来决定是否加载配置

人家源代码这点没毛病的,是可以生成custom.ini配置文件的。你把ConfigureServiceHandler那几行代码删了,反而导致configs集合为空,不生成配置文件。
1737613575516

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants