Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update server-reason-react to latest #524

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Update server-reason-react to latest #524

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1ea00a0
chore: bump server-reason-react
pedrobslisboa Dec 3, 2024
fc997f9
feat: change JSX variants to handle jsx prop name
pedrobslisboa Dec 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/runtime/native/CSS.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -485,8 +485,8 @@ let get_string_style_hashes () =
let style_tag ?key:_ ?children:_ () =
React.createElement "style"
[
String ("data-emotion", "css " ^ get_string_style_hashes ());
Bool ("data-s", true);
String ("data-emotion", "data-emotion", "css " ^ get_string_style_hashes ());
Bool ("data-s", "data-s", true);
DangerouslyInnerHtml (get_stylesheet ());
]
[]
Expand Down
4 changes: 4 additions & 0 deletions styled-ppx.opam
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,3 +46,7 @@ dev-repo: "git+https://github.com/davesnx/styled-ppx.git"
depexts: [
["@emotion/css"] {npm-version = ">=11.0.0"}
]

pin-depends: [
["server-reason-react.0.3.1" "git+https://github.com/ml-in-barcelona/server-reason-react#ea16c107cd41a2e9d01dff358239eec37046951f"]
]
4 changes: 4 additions & 0 deletions styled-ppx.opam.template
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
depexts: [
["@emotion/css"] {npm-version = ">=11.0.0"}
]

pin-depends: [
["server-reason-react.0.3.1" "git+https://github.com/ml-in-barcelona/server-reason-react#ea16c107cd41a2e9d01dff358239eec37046951f"]
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might need to add it on the "pin" command in the makefile for the CI to work

]
Loading