Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the persistence filter code compatible with the MacOS.
Specifically, I added instructions for getting dependencies and compiling on MacOS and additionally made the following modifications:
-std=c++11
for all non-GNU CXX compiles (Apple uses AppleClang).libgsl
when it is installed via brew on Apple machines. This is protected by anif (APPLE)
condition inCMakeLists.txt
so it should have no compatibility issues.boost-python3
in the environment variableBOOST_LIBRARYDIR
(seeREADME.md
). This also requires specifying the version of (and path to headers for) your Python installation.There was also apparently a syntax error with a lambda capture in
persistence_filter_test.cc
(see the diff). This could have been some kind of library or compiler versioning issue, though. I'm not certain.Caveats:
README.md
about what to change for MacOS users who may have different versions of e.g. Python, Boost, etc, which I hope would be useful to a user needing to modify this information.