Better debug for repo/environment secrets and variables when a value …

…is missing
davidcarboni · Nov 29, 2023 · d010efe · d010efe
1 parent daac12d
commit d010efe
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/cdk-github/src/environment.ts b/cdk-github/src/environment.ts
@@ -99,7 +99,7 @@ export async function setEnvironmentSecret(
   repo: string,
   environment: string,
 ): Promise<string> {
-  if (!secretValue) throw new Error(`No value for secret ${secretName}`);
+  if (!secretValue) throw new Error(`No value for environment secret ${secretName} (${owner}/${repo} - ${environment})`);
   const environmentPublicKey = await getEnvironmentPublicKey(owner, repo, environment);
   const encryptedValue = await encrypt(secretValue, environmentPublicKey.key);
   const repoId = await getRepoId(owner, repo);
@@ -135,7 +135,7 @@ export async function setEnvironmentVariable(
   repo: string,
   environment: string,
 ): Promise<string> {
-  if (!value) throw new Error(`No value for variable ${name}`);
+  if (!value) throw new Error(`No value for environment variable ${name} (${owner}/${repo} - ${environment}))`);
   try {
     // Most likely we're updating an existing variable:
     const response = await octokit.rest.actions.updateEnvironmentVariable({

diff --git a/cdk-github/src/repo.ts b/cdk-github/src/repo.ts
@@ -112,7 +112,7 @@ export async function setRepoSecret(
   owner: string,
   repo: string,
 ): Promise<string> {
-  if (!secretValue) throw new Error(`No value for secret ${secretName}`);
+  if (!secretValue) throw new Error(`No value for repo secret ${secretName} (${owner}/${repo})`);
   const publicKey = await getRepoPublicKey(owner, repo);
   const encryptedValue = await encrypt(secretValue, publicKey.key);
   const response = await octokit.actions.createOrUpdateRepoSecret({
@@ -137,7 +137,7 @@ export async function setRepoVariable(
   owner: string,
   repo: string,
 ): Promise<string> {
-  if (!value) throw new Error(`No value for variable ${name}`);
+  if (!value) throw new Error(`No value for repo variable ${name} (${owner}/${repo}))`);
   try {
     // Most likely we're updating an existing variable:
     const response = await octokit.rest.actions.updateRepoVariable({