feat: add support for HTTP proxies #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fgreinacher
commented
Mar 25, 2024
|
@davideicardi Let me know if something is missing, I'm happy to rework as needed. |
|
LGTM! Thank you @fgreinacher ! |
|
Thanks @davideicardi! I have just rebased my branch. Ready for another round 🙇 |
|
Thank you!! |
|
Thanks for merging @davideicardi, if you could also create a new release that would be awesome 🙇 |
|
@fgreinacher Just released v0.19.0! |
Thanks a ton ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for HTTP proxies configured in environment variables.
I think it's best to not have an option for this and do the right thing out of the box (like cURL, axios, npm and many others)
Closes #48
⚒️ with ❤️ by Siemens