perf: use pure annotations for tree shaking #1043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidlj95
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1043 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 89 89
Lines 389 389
Branches 49 49
=========================================
Hits 389 389 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
📦 Bundle size (Angular v18)Git ref:
Base size data is not available yet. Try again when the CI/CD has finished running on main branch |
📦 Bundle size (Angular v15)Git ref:
Base size data is not available yet. Try again when the CI/CD has finished running on main branch |
📦 Bundle size (Angular v17)Git ref:
Base size data is not available yet. Try again when the CI/CD has finished running on main branch |
📦 Bundle size (Angular v16)Git ref:
Base size data is not available yet. Try again when the CI/CD has finished running on main branch |
|
🎉 This PR is included in version 1.0.0-beta.34 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue or need
After seeing a pure annotation to
RouterTitleKeysymbol in Angular's router package, the use of pure annotations has given me several ideas:constsApplying here the pure annotation when possible to improve tree shaking
Proposed changes
Use pure annotation to tree shake:
ANGULAR_ROUTER_URLsymbol if unused. It's the only symbol used aroundReviewed the API report and nothing else seems to bee applicable for optimizations using pure annotations.
Tested that the symbol is not in production bundle when removing its usage in example app + not providing
withBaseUrlQuick reminders