Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(e2e): remove unneded extra env var #696

Merged
merged 1 commit into from
Jul 20, 2024

Conversation

davidlj95
Copy link
Owner

Issue or need

If naming cypress_cache_dir as Cypress wants (CYPRESS_CACHE_FOLDER), we don't need to define cypress_cache_dir

Proposed changes

Follow Cypress namings for cache dir

Quick reminders

  • 🤝 I will follow Code of Conduct
  • No existing pull request already does almost same changes
  • 👁️ Contributing docs are something I've taken a look at
  • 📝 Commit messages convention has been followed
  • 💬 TSDoc comments have been added or updated indicating API visibility if API surface has changed.
  • 🧪 Tests have been added if needed. For instance, if adding new features or fixing a bug. Or removed if removing features.
  • ⚙️ API Report has been updated if API surface is altered.

@davidlj95 davidlj95 enabled auto-merge (squash) July 20, 2024 16:14
Copy link
Owner Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @davidlj95 and the rest of your teammates on Graphite Graphite

Copy link

codecov bot commented Jul 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.68%. Comparing base (447b2bc) to head (1694760).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #696   +/-   ##
=======================================
  Coverage   97.68%   97.68%           
=======================================
  Files          72       72           
  Lines         346      346           
  Branches       61       61           
=======================================
  Hits          338      338           
  Misses          3        3           
  Partials        5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@davidlj95 davidlj95 merged commit 889af34 into main Jul 20, 2024
31 checks passed
@davidlj95 davidlj95 deleted the stacked/ci-e2e-remove-unneded-extra-env-var branch July 20, 2024 16:18
Copy link

github-actions bot commented Aug 2, 2024

🎉 This PR is included in version 1.0.0-beta.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant