Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): update to Angular v18.1 #703

Merged
merged 1 commit into from
Aug 1, 2024

Conversation

davidlj95
Copy link
Owner

@davidlj95 davidlj95 commented Jul 21, 2024

Issue or need

Proposed changes

Updates to Angular v18.1

Typescript updated to 5.5 also in order to fix an issue with builds

Quick reminders

  • 🀝 I will follow Code of Conduct
  • βœ… No existing pull request already does almost same changes
  • πŸ‘οΈ Contributing docs are something I've taken a look at
  • πŸ“ Commit messages convention has been followed
  • πŸ’¬ TSDoc comments have been added or updated indicating API visibility if API surface has changed.
  • πŸ§ͺ Tests have been added if needed. For instance, if adding new features or fixing a bug. Or removed if removing features.
  • βš™οΈ API Report has been updated if API surface is altered.

@davidlj95 davidlj95 enabled auto-merge (squash) July 21, 2024 20:50
Copy link
Owner Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @davidlj95 and the rest of your teammates on Graphite Graphite

Copy link

codecov bot commented Jul 21, 2024

Codecov Report

All modified and coverable lines are covered by tests βœ…

Project coverage is 97.16%. Comparing base (d532c6e) to head (7886a7d).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #703   +/-   ##
=======================================
  Coverage   97.16%   97.16%           
=======================================
  Files          68       68           
  Lines         317      317           
  Branches       54       54           
=======================================
  Hits          308      308           
  Partials        9        9           

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

@davidlj95
Copy link
Owner Author

Angular builds fail due to the mentioned issue.

If upgrading Typescript, API Extractor isn't ready yet

So leaving this on hold for a while until one of those gets fixed

@davidlj95 davidlj95 marked this pull request as draft July 21, 2024 22:49
auto-merge was automatically disabled July 21, 2024 22:49

Pull request was converted to draft

@davidlj95
Copy link
Owner Author

Angular issue regarding Typescript 5.4 compatibility has been fixed
angular/angular@f0d6d06

Will be released in next patch I guess

@davidlj95 davidlj95 force-pushed the stacked/build-deps-update-to-angular-v18.1 branch from 03d1793 to b2c9f72 Compare July 24, 2024 16:25
@davidlj95 davidlj95 force-pushed the stacked/build-deps-update-to-angular-v18.1 branch from b2c9f72 to 7886a7d Compare August 1, 2024 23:25
@davidlj95 davidlj95 marked this pull request as ready for review August 1, 2024 23:27
@davidlj95
Copy link
Owner Author

Weeeelll some updates here

Opened an issue providing a minimal reproduction of the issue, as the first fix for the issue didn't fix it for all cases. A second fix was merged days later and...

Now in Angular v18.1.3 release seems it's definitely fixed πŸŽ‰ So finally unblocking the upgrade πŸ’ͺ

@davidlj95 davidlj95 enabled auto-merge (squash) August 1, 2024 23:29
@davidlj95 davidlj95 merged commit d3ec2f1 into main Aug 1, 2024
34 checks passed
@davidlj95 davidlj95 deleted the stacked/build-deps-update-to-angular-v18.1 branch August 1, 2024 23:31
Copy link

github-actions bot commented Aug 2, 2024

πŸŽ‰ This PR is included in version 1.0.0-beta.6 πŸŽ‰

The release is available on:

Your semantic-release bot πŸ“¦πŸš€

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant