-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(deps): update to Angular v18.1 #703
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @davidlj95 and the rest of your teammates on Graphite |
Codecov ReportAll modified and coverable lines are covered by tests β
Additional details and impacted files@@ Coverage Diff @@
## main #703 +/- ##
=======================================
Coverage 97.16% 97.16%
=======================================
Files 68 68
Lines 317 317
Branches 54 54
=======================================
Hits 308 308
Partials 9 9 β View full report in Codecov by Sentry. |
Angular builds fail due to the mentioned issue. If upgrading Typescript, API Extractor isn't ready yet So leaving this on hold for a while until one of those gets fixed |
Angular issue regarding Typescript 5.4 compatibility has been fixed Will be released in next patch I guess |
03d1793
to
b2c9f72
Compare
b2c9f72
to
7886a7d
Compare
Weeeelll some updates here Opened an issue providing a minimal reproduction of the issue, as the first fix for the issue didn't fix it for all cases. A second fix was merged days later and... Now in Angular v18.1.3 release seems it's definitely fixed π So finally unblocking the upgrade πͺ |
π This PR is included in version 1.0.0-beta.6 π The release is available on: Your semantic-release bot π¦π |
Issue or need
Proposed changes
Updates to Angular v18.1
Typescript updated to 5.5 also in order to fix an issue with builds
Quick reminders