Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: reduce complexity #709

Merged
merged 3 commits into from
Jul 22, 2024

Conversation

davidlj95
Copy link
Owner

@davidlj95 davidlj95 commented Jul 22, 2024

Issue or need

CI/CD GitHub Actions workflows are a bit verbose. Some improvement opportunities:

  • inputs.ref is defined in every workflow to allow to use it at any git ref. However, has never been used.
  • Artifact name constants are defined in many places: inputs of workflows uploading artifacts, inputs of workflows downloading artifacts and in main / pull_request workflows passing those inputs. This was done to ensure values match. However, that can be done in other ways. It's not expected for those constants to be different depending on the workflow calling the reusable workflows anyway

Proposed changes

Tackle improvements:

  • Remove ref input from reusable workflows
  • Move artifact name constants to env in each reusable workflow that needs them
  • Remove useless if clauses given artifact names are now always defined
  • Artifact name constants to always be suffixes to allow for more projects in the future (decouple from ngx-meta in those names)

Quick reminders

  • 🤝 I will follow Code of Conduct
  • No existing pull request already does almost same changes
  • 👁️ Contributing docs are something I've taken a look at
  • 📝 Commit messages convention has been followed
  • 💬 TSDoc comments have been added or updated indicating API visibility if API surface has changed.
  • 🧪 Tests have been added if needed. For instance, if adding new features or fixing a bug. Or removed if removing features.
  • ⚙️ API Report has been updated if API surface is altered.

Copy link
Owner Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @davidlj95 and the rest of your teammates on Graphite Graphite

@davidlj95
Copy link
Owner Author

image

Noice 🎉 ✨

@davidlj95 davidlj95 force-pushed the stacked/ci-remove-unneeded-if-clauses-in-workflows branch from efde006 to a66b033 Compare July 22, 2024 22:01
Copy link

codecov bot commented Jul 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.68%. Comparing base (e903552) to head (a66b033).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #709   +/-   ##
=======================================
  Coverage   97.68%   97.68%           
=======================================
  Files          72       72           
  Lines         346      346           
  Branches       61       61           
=======================================
  Hits          338      338           
  Misses          3        3           
  Partials        5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@davidlj95 davidlj95 merged commit e5c3e84 into main Jul 22, 2024
31 checks passed
@davidlj95 davidlj95 deleted the stacked/ci-remove-unneeded-if-clauses-in-workflows branch July 22, 2024 22:13
Copy link

github-actions bot commented Aug 2, 2024

🎉 This PR is included in version 1.0.0-beta.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant