-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: use lazy injection token for head utility #902
refactor: use lazy injection token for head utility #902
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @davidlj95 and the rest of your teammates on Graphite |
19dc4b4
to
0cc4425
Compare
0cc4425
to
c963bb7
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #902 +/- ##
=======================================
Coverage 99.46% 99.46%
=======================================
Files 79 79
Lines 372 373 +1
Branches 73 73
=======================================
+ Hits 370 371 +1
Partials 2 2 ☔ View full report in Codecov by Sentry. |
c963bb7
to
4e501a6
Compare
4e501a6
to
e8b541b
Compare
📦 Bundle size (Angular v15)Git ref:
|
📦 Bundle size (Angular v17)Git ref:
|
📦 Bundle size (Angular v16)Git ref:
|
📦 Bundle size (Angular v18)Git ref:
|
🎉 This PR is included in version 1.0.0-beta.17 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Issue or need
After #892 lazy injection tokens are ready to use. Head element upsert or remove is a good start to use it. Because of #891
Proposed changes
Use lazy injection token for head element upsert or remove util
Verified that if usages of this token disappear (i.e.: removing standard + JSON LD modules from example app), the injection token and its factory get tree shaken.
Quick reminders