Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On connect, only call readGpsCompassBaseline if on a vn-300 #60

Merged
merged 3 commits into from
Apr 14, 2021

Conversation

jfinken
Copy link

@jfinken jfinken commented Apr 13, 2021

@dawonn
Copy link
Owner

dawonn commented Apr 14, 2021

Does the get the end device family query the device every single loop? If so it might be better to cash it at startup and then just use the cash value in the loop.

@jfinken
Copy link
Author

jfinken commented Apr 14, 2021

Does the get the end device family query the device every single loop? If so it might be better to cash it at startup and then just use the cash value in the loop.

Sorry, which loop? In vectornav.cc, I am only calling determineDeviceFamily() in the public connect() function. So this should only get called once when connecting to the sensor, unless I am missing something.

@dawonn
Copy link
Owner

dawonn commented Apr 14, 2021

You're right, I didn't looks close enough. ;)

@dawonn dawonn merged commit c9b564d into dawonn:ros2 Apr 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants