-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(persist_docs): write dbt model and project metadata to properties #449
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall the codes looks good, but it seems like a lot of new metadata, would it be possible to think of a way to activate or not this feature or to be at least able to customize which keys we want to push ?
Also please provide some unit tests :)
Well, I thought about it... Then I decided that Athena and Glue store lots of trash in Table Properties you will never use. Why should we be humble then? |
I believe that is not necessary for this case. |
Ok ok let's go for this then :)
I think there is something like 255 characters |
It's a very good point. I'm going to truncate long values and omit long keys. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯 @Jrmyy do you want to do another round of checks?
Description
Hi team, I suggest improvement which should significantly improve data observability from my point of view.
If
persist_docs
is enabled we write additional metadata to Glue Table Properties:model.config.meta
(i.e. owner, unique_key, other custom fields)model.config.materialized
value (to mark incremental tables)This improvement allows to treat Glue Catalog as a storage of tabel metadata and build interactive application around it without need to access dbt manifest.
Models used to test - Optional
Tested on view, table, incremental table
Checklist