-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: check_exclude_cols option #10488
base: main
Are you sure you want to change the base?
Conversation
I'm also not really sure what the best way of handling the regenerated schema is. |
Normally when we need to reference a branch in another repo we update the dev-requirements.txt file and specify it there. Then remove it when the pr is approved and we're ready to merge. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10488 +/- ##
==========================================
- Coverage 88.86% 84.87% -3.99%
==========================================
Files 180 180
Lines 22560 22648 +88
==========================================
- Hits 20047 19222 -825
- Misses 2513 3426 +913
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Thanks! will do this now |
Resolves #10438
This is failing tests but that's because the
dbt-adapters
PR here needs merging first. If anyone has any guidance on how to get my dbt-core pointing at my dev branch of dbt-adapters so I can look at the tests, then let me know!Problem
Want a more streamlined way of doing multi-column check strategies.
Solution
Having a check_exclude_columns option
Checklist