Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove experimental parser tests #10

Merged
merged 2 commits into from
Feb 12, 2024
Merged

Conversation

mikealfare
Copy link
Contributor

@mikealfare mikealfare commented Feb 12, 2024

Problem

These tests are not relevant to dbt-postgres. They test dbt-core functionality.

Solution

  • Remove experimental parser tests from dbt-postgres
  • Leave experimental parser tests in dbt-core
  • Migrate get catalog unit tests from dbt-postgres to dbt-adapters

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@mikealfare mikealfare self-assigned this Feb 12, 2024
@mikealfare mikealfare merged commit 3b8647c into main Feb 12, 2024
9 checks passed
@mikealfare mikealfare deleted the tests/experimental-parser branch February 12, 2024 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants