Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add method to _connection_keys #336

Closed
wants to merge 1 commit into from
Closed

Conversation

jtcohen6
Copy link
Contributor

resolves #335

Description

Checklist

  • I have signed the CLA
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have updated the CHANGELOG.md and added information about my change to the "dbt-spark next" section.

@cla-bot cla-bot bot added the cla:yes label Apr 18, 2022
@jtcohen6
Copy link
Contributor Author

jtcohen6 commented Apr 18, 2022

This didn't "just work" in the way I might have hoped :) will take a bit more experimentation. The right answer here may just look like additional logging within connection.py—the same SQL, after sqlparam conversion—if the swap from ? for %s can't happen within the templating/Jinja layer.

@jtcohen6 jtcohen6 closed this Jun 2, 2022
@mikealfare mikealfare deleted the target-method-binding-param branch March 1, 2023 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CT-503] Add method to target keys
2 participants