Skip to content

Commit

Permalink
Bump upper bound to <0.22 (#398)
Browse files Browse the repository at this point in the history 
* Bump upper bound to <0.22

* Add changelog entry
  • Loading branch information
@jtcohen6
jtcohen6 authored Aug 6, 2021
1 parent 7c9775b commit 696cf26
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 2 deletions.
6 changes: 5 additions & 1 deletion CHANGELOG.md
View file
Original file line number Diff line number Diff line change
@@ -1,4 +1,8 @@
# dbt-utils Next
# dbt-utils v0.7.1

## Under the hood

- Declare compatibility with dbt v0.21.0, which has no breaking changes for this package ([#398](https://github.com/fishtown-analytics/dbt-utils/pull/398))


# dbt-utils v0.7.0
Expand Down
2 changes: 1 addition & 1 deletion dbt_project.yml
View file
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name: 'dbt_utils'
version: '0.7.0'

This comment has been minimized.

Sign in to view

Copy link
@eugene-nikolaev

eugene-nikolaev Sep 6, 2021

@jtcohen6 is that OK it is still declared '0.7.0' here?

This comment has been minimized.

Sign in to view

Copy link
@jtcohen6

jtcohen6 Sep 7, 2021

Author Contributor

Hey @eugene-nikolaev, good callout. This version doesn't serve a functional purpose, it's just cosmetic. To avoid user confusion, we should keep this up to date to the best of our ability, but it isn't currently part of any automated upgrade process for this package.

require-dbt-version: [">=0.20.0", "<0.21.0"]
require-dbt-version: [">=0.20.0", "<0.22.0"]

config-version: 2

Expand Down

2 comments on commit 696cf26

@zestyping
Copy link

@zestyping zestyping commented on 696cf26 Sep 30, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! A note that I'm hoping will be helpful for the future: we tried to use dbt-utils and found ourselves stuck because there's no version of dbt-utils that declares itself compatible with both dbt 0.19.0 and dbt 0.20.0. There's a version that is compatible with only 0.19.x, and a version that's compatible with only 0.20.x. (We need a version that's compatible with both because Airbyte is on 0.19.0, but only 0.20.0 runs on Mac M1 machines.)

It's probably unnecessary to set the upper bound so conservatively; dbt-utils 0.6.6 still works with dbt 0.20.0, but it won't run because this file imposes <0.20.0. To avoid this problem in the future, you might consider removing the <0.22.0 part of the requirement, or at least raising it to the next major version instead of minor version.

@jtcohen6
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zestyping Really appreciate your comment, and I share your aspiration for looser upper boundaries on the dbt-core version.

There were breaking changes to dbt-utils in dbt Core v0.20, namely the schema generic tests and some behind-the-scenes changes to dispatch functionality (#371). Of course, it's quite possible that you're using dbt_utils macros that were unaffected by these changes.

There are two things we're planning to make this simpler in the future:

  • Release dbt-core v1.0. After that, project code will not break in new minor versions. If we make changes, they must be backwards compatible. So we should feel comfortable saying that, if dbt-utils macros work with dbt-core==1.0.0, they will work with all versions 1.x.y.
  • Split up this package! It doesn't make sense that a change to generic tests requires you to struggle through upgrading, if you're only relying on dbt_utils.datediff, a macro that hasn't changed at all.

Please sign in to comment.