Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added description section to data tests doc #6867

Merged
merged 14 commits into from
Feb 6, 2025

Conversation

nataliefiann
Copy link
Contributor

@nataliefiann nataliefiann commented Feb 4, 2025

What are you changing in this pull request and why?

I have created this PR following a request from Karanke who reported a user queried how to add a description to data tests (generic / singular) in the community slack.

Checklist

  • I have reviewed the Content style guide so my content adheres to these guidelines.
  • The topic I'm writing about is for specific dbt version(s) and I have versioned it according to the version a whole page and/or version a block of content guidelines.
  • I have added checklist item(s) to this list for anything anything that needs to happen before this PR is merged, such as "needs technical review" or "change base branch."
  • The content in this PR requires a dbt release note, so I added one to the release notes page.

🚀 Deployment available! Here are the direct links to the updated files:

@nataliefiann nataliefiann requested a review from a team as a code owner February 4, 2025 16:59
Copy link

vercel bot commented Feb 4, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview Feb 6, 2025 2:10pm

@github-actions github-actions bot added content Improvements or additions to content size: small This change will take 1 to 2 days to address labels Feb 4, 2025
@aranke
Copy link
Member

aranke commented Feb 4, 2025

Thanks for jumping on this, @nataliefiann!

Can we add an example for description to the "Property file" sections also, please?
Otherwise LGTM 😄

@nataliefiann
Copy link
Contributor Author

Thanks for jumping on this, @nataliefiann!

Can we add an example for description to the "Property file" sections also, please? Otherwise LGTM 😄

@nataliefiann nataliefiann reopened this Feb 5, 2025
@nataliefiann
Copy link
Contributor Author

Hiya @aranke

Thanks so much for reviewing this. I added some examples at the bottom of the page. Would you like me to use these examples under the Profile tab or a new one?

Kind Regards
Natalie

Screenshot 2025-02-05 at 09 42 39

@nataliefiann nataliefiann merged commit 441e2d4 into current Feb 6, 2025
8 checks passed
@nataliefiann nataliefiann deleted the nfiann-description-datatests branch February 6, 2025 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content size: small This change will take 1 to 2 days to address
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants