Skip to content

Commit

Permalink
change helm back-off limit
Browse files Browse the repository at this point in the history
  • Loading branch information
dbw7 committed Aug 23, 2024
1 parent e733e80 commit 192af38
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 0 deletions.
1 change: 1 addition & 0 deletions RELEASE_NOTES.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@

* Improved Kubernetes definition validation
* Allow RKE2 deployments with Calico, Cilium and Multus on aarch64 platforms
* Helm chart installation backOffLimit changed from 1000(default) to 20

## API

Expand Down
1 change: 1 addition & 0 deletions pkg/combustion/kubernetes_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -719,6 +719,7 @@ spec:
chartContent: some-content
targetNamespace: web
createNamespace: true
backOffLimit: 20
`
b, err = os.ReadFile(chartPath)
require.NoError(t, err)
Expand Down
4 changes: 4 additions & 0 deletions pkg/registry/helm_crd.go
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ const (
helmChartAPIVersion = "helm.cattle.io/v1"
helmChartKind = "HelmChart"
helmChartSource = "edge-image-builder"
helmBackoffLimit = 20
)

type HelmCRD struct {
Expand All @@ -26,6 +27,7 @@ type HelmCRD struct {
ChartContent string `yaml:"chartContent"`
TargetNamespace string `yaml:"targetNamespace,omitempty"`
CreateNamespace bool `yaml:"createNamespace,omitempty"`
BackOffLimit int `yaml:"backOffLimit"`
} `yaml:"spec"`
}

Expand Down Expand Up @@ -53,12 +55,14 @@ func NewHelmCRD(chart *image.HelmChart, chartContent, valuesContent, repositoryU
ChartContent string `yaml:"chartContent"`
TargetNamespace string `yaml:"targetNamespace,omitempty"`
CreateNamespace bool `yaml:"createNamespace,omitempty"`
BackOffLimit int `yaml:"backOffLimit"`
}{
Version: chart.Version,
ValuesContent: valuesContent,
ChartContent: chartContent,
TargetNamespace: chart.TargetNamespace,
CreateNamespace: chart.CreateNamespace,
BackOffLimit: helmBackoffLimit,
},
}
}

0 comments on commit 192af38

Please sign in to comment.