Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build-monitor-plugin request permission #1

Closed
wants to merge 1 commit into from

Conversation

dcendents
Copy link
Owner

Description

Hi, I'd like to request permission for myself @dcendents to contribute on build-monitor-plugin: https://github.com/jenkinsci/build-monitor-plugin.

I was invited by @basil
jenkinsci/build-monitor-plugin#573 (comment)

P.S: sorry for the delay to submit my PR, March is always hectic at work.

Regards,

Submitter checklist for adding or changing permissions

Always

  • Add link to plugin/component Git repository in description above

When enabling automated releases (cd: true)

  • Add a link to the pull request, which enables continuous delivery for your plugin or component.
    Follow the documentation to ensure, your pull request is set up properly.

When adding new uploaders (this includes newly created permissions files)

Reviewer checklist (not for requesters!)

  • Check this if newly added person also needs to be given merge permission to the GitHub repo (please @ the people/person with their GitHub username in this issue as well). If needed, it can be done using an IRC Bot command
  • Check that the $pluginId Developers team has Admin permissions while granting the access.
  • In the case of plugin adoption, ensure that the Jenkins Jira default assignee is either removed or changed to the new maintainer.
  • If security contacts are changed (this includes add/remove), ping the security officer (currently @Wadeck) in this pull request. If an email contact is changed, wait for approval from the security officer.

There are IRC Bot commands for it

Copy link

@basil basil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to see you coming on board!

@basil
Copy link

basil commented Apr 9, 2023

@dcendents You submitted this pull request to your fork, not https://github.com/jenkins-infra/repository-permissions-updater

@dcendents
Copy link
Owner Author

@basil silly me!
It was such a small change I did it directly from the web and followed github forms to create the PR, I did not realise it selected my own master branch.

I've created it properly this time: jenkins-infra#3241

Thanks

@dcendents dcendents closed this Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants