Allow port forwarding from any host IP #171
Conversation
|
@AdrianVollmer currently the tests of this are broken, please let me know if you want to fix them or if I shall take it over. |
|
I'll take a look later. The nox tests were fine on my system AFAIC. I'll let you know when I need help |
AdrianVollmer
force-pushed
the
allow_bind_ip
branch
2 times, most recently
from
323b26e to
3a3ee8f
Compare
|
Let's try again |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #171 +/- ##
==========================================
- Coverage 94.64% 94.50% -0.15%
==========================================
Files 9 9
Lines 1064 1073 +9
Branches 221 224 +3
==========================================
+ Hits 1007 1014 +7
- Misses 43 44 +1
- Partials 14 15 +1 ☔ View full report in Codecov by Sentry. |
AdrianVollmer
force-pushed
the
allow_bind_ip
branch
from
3a3ee8f to
739d5d2
Compare
|
Added the tests. Coverage passes on my system. Third time's the charm :) |
| @@ -12,6 +12,10 @@ Breaking changes: | |||
| Improvements and new features: | |||
|
|
|||
|
|
|||
| - Add property :py:attr:`~pytest_container.inspect.PortForwarding.bind_ip` | |||
| to support binding to arbitrary IP addresses. | |||
|
|
|||
There was a problem hiding this comment.
You fixed this one too:
| - Fix :py:attr:`~pytest_container.inspect.PortForwarding.host_port` being | |
| ignored when picking the host port |
See dcermak#169. With this commit we are able to define the bind IP address when using port forwarding, which will be passed to `--publish` of podman-run. Also, it fixes the `host_port` being ignored when specifying the host port.
AdrianVollmer
force-pushed
the
allow_bind_ip
branch
from
739d5d2 to
505bc38
Compare
|
No problem. Thanks for your comments. Unfortunately I don't know how fix that codecov check. If you have an idea how to write a test for that line, feel free to just edit this PR branch. |
See #169. With this commit we are able to define the bind IP address when using port forwarding, which will be passed to
--publishof podman-run.Note: I did not quite understand your logic
create_host_port_port_forward(). In the returnedPortForwardobjects,host_portis always random. I believe this to be a bug, so please check my change here if it makes sense. I can split it into a separate PR if you want.