Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error message for auto_container* fixtures #180

Merged
merged 1 commit into from
Dec 26, 2023

Conversation

dcermak
Copy link
Owner

@dcermak dcermak commented Dec 18, 2023

If the user does not add the auto_container_parametrize call to pytest_generate_tests() in conftest.py, then they get a weird error message. This commit improves the error message, indicating where the issue might be.

If the user does not add the `auto_container_parametrize` call to
`pytest_generate_tests()` in `conftest.py`, then they get a weird error
message. This commit improves the error message, indicating where the issue
might be.
This should make it easier to spot issues like
#179 easier.
@dcermak dcermak enabled auto-merge December 18, 2023 11:06
Copy link

codecov bot commented Dec 26, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (9319bf5) 94.70% compared to head (605c7df) 94.53%.

Files Patch % Lines
pytest_container/plugin.py 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #180      +/-   ##
==========================================
- Coverage   94.70%   94.53%   -0.18%     
==========================================
  Files           9        9              
  Lines        1076     1079       +3     
  Branches      218      224       +6     
==========================================
+ Hits         1019     1020       +1     
- Misses         43       45       +2     
  Partials       14       14              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dcermak dcermak merged commit 38f5c66 into main Dec 26, 2023
35 of 37 checks passed
@dcermak dcermak deleted the auto-container-err-msg branch December 26, 2023 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant