Don't use md5 for computing the lockfile filename #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grisu48
previously approved these changes
Jul 1, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #212 +/- ##
==========================================
- Coverage 94.93% 94.92% -0.01%
==========================================
Files 9 9
Lines 1105 1103 -2
Branches 229 229
==========================================
- Hits 1049 1047 -2
Misses 42 42
Partials 14 14 ☔ View full report in Codecov by Sentry. |
dirkmueller
reviewed
Jul 1, 2024
dirkmueller
previously approved these changes
Jul 1, 2024
grisu48
previously approved these changes
Jul 1, 2024
dcermak
force-pushed
the
dont-use-md5
branch
2 times, most recently
from
2423eb3 to
937d04a
Compare
dirkmueller
previously approved these changes
Jul 1, 2024
md5 is forbidden in FIPS mode, rely on sha3-256 instead
For $reasons, python 3.12.4 causes issues with Sphinx no longer correctly recognizing its nitpicky allowlist when performing a `from $smth import foo`. But `import $smth` and then using `$smth.foo` directly works, so we use that ¯\_(ツ)_/¯
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
md5 is forbidden in FIPS mode, rely on SHA256 instead
This fixes #213