Make Container, DerivedContainer & Pod inherit from ParameterSet #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #216 +/- ##
==========================================
+ Coverage 96.73% 97.18% +0.45%
==========================================
Files 9 9
Lines 1101 1207 +106
Branches 164 172 +8
==========================================
+ Hits 1065 1173 +108
+ Misses 23 21 -2
Partials 13 13 ☔ View full report in Codecov by Sentry. |
dcermak
force-pushed
the
inherit-marks
branch
4 times, most recently
from
5c3f7e4 to
bdb8375
Compare
dcermak
changed the title
dcermak
force-pushed
the
inherit-marks
branch
5 times, most recently
from
1031d79 to
9404424
Compare
dcermak
force-pushed
the
inherit-marks
branch
2 times, most recently
from
89b9016 to
93bb2e4
Compare
dcermak
force-pushed
the
inherit-marks
branch
from
93bb2e4 to
1c0230f
Compare
We can't do anything about the number of instance attributes, because they are mandated by the output of `podman container inspect`
pathlib.Path is automatically resolved to the local implementation by sphinx autodoc, which then cannot be found by intersphinx.
It just takes time for no benefit
dcermak
force-pushed
the
inherit-marks
branch
from
1c0230f to
de27761
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.