Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use official github action #21

Merged
merged 2 commits into from
Feb 27, 2024

Conversation

tyler36
Copy link
Contributor

@tyler36 tyler36 commented Feb 26, 2024

The new image helps centralize many common steps and makes for easier maintainence:

https://github.com/ddev/github-action-add-on-test

@tyler36 tyler36 force-pushed the 20240227_move_to_official_github_action branch from a0de42a to 68e58c7 Compare February 26, 2024 23:59
@tyler36 tyler36 force-pushed the 20240227_move_to_official_github_action branch from 68e58c7 to 1a9f5ff Compare February 27, 2024 00:00
Copy link
Member

@rfay rfay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

.github/workflows/tests.yml Outdated Show resolved Hide resolved
Test passes with this. If it starts to fail, revert this.
@tyler36
Copy link
Contributor Author

tyler36 commented Feb 27, 2024

I remove the line. We'll see if the tests fail. :)

Copy link
Member

@stasadev stasadev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@stasadev stasadev merged commit d1d88b5 into ddev:main Feb 27, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants