Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2130 gut modify table styling #2131

Merged
merged 5 commits into from
Jan 29, 2025
Merged

2130 gut modify table styling #2131

merged 5 commits into from
Jan 29, 2025

Conversation

ddsjoberg
Copy link
Owner

@ddsjoberg ddsjoberg commented Jan 29, 2025

What changes are proposed in this pull request?

Also removed calculations from modify_table_styling() to the individual modify functions where possible.

If there is an GitHub issue associated with this pull request, please provide link.
closes #2130


Reviewer Checklist (if item does not apply, mark is as complete)

  • PR branch has pulled the most recent updates from main branch.
  • If a bug was fixed, a unit test was added.
  • Run pkgdown::build_site(). Check the R console for errors, and review the rendered website.
  • Code coverage is suitable for any new functions/features: devtools::test_coverage()
  • usethis::use_spell_check() runs with no spelling errors in documentation
  • All GitHub Action workflows pass with a ✅

When the branch is ready to be merged into master:

  • Update NEWS.md with the changes from this pull request under the heading "# gtsummary (development version)". If there is an issue associated with the pull request, reference it in parentheses at the end update (see NEWS.md for examples).
  • Increment the version number using usethis::use_version(which = "dev")
  • Run usethis::use_spell_check() again
  • Approve Pull Request
  • Merge the PR. Please use "Squash and merge".

@ddsjoberg ddsjoberg merged commit 530c10e into main Jan 29, 2025
7 checks passed
@ddsjoberg ddsjoberg deleted the 2130-gut-modify_table_styling branch January 29, 2025 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant