Skip to content

Commit

Permalink
further improvements to error message
Browse files Browse the repository at this point in the history
  • Loading branch information
emilwareus committed Dec 12, 2023
1 parent 146ee6d commit 78976e8
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion internal/resolution/pm/pip/job.go
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,7 @@ func (j *Job) handleInstallError(cmdErr job.IError) {
[]string{
"Failed to find a version that satisfies the requirement for python dependency ",
dependencyName,
". This could mean that the specified version or version does not exist.\n" + util.InstalLPrivateDependencyMessage,
". This could mean that the package or version does not exist.\n" + util.InstalLPrivateDependencyMessage,
}, ""),
)
}
Expand Down
2 changes: 1 addition & 1 deletion internal/resolution/pm/util/error.go
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ func NewPMJobError(err string) *PMJobError {
return &PMJobError{
err: err,
cmd: "",
doc: "No specific documentation for this problem yet, please create an issue here: https://github.com/debricked/cli/issues",
doc: "No specific documentation for this problem yet. If you would like this message to more informative for this error, please create an issue here: https://github.com/debricked/cli/issues",
status: "",
}
}
2 changes: 1 addition & 1 deletion internal/resolution/pm/util/error_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ func TestPMJobErrorSetDocumentation(t *testing.T) {
jobError := NewPMJobError("")
assert.Equal(
t,
string("No specific documentation for this problem yet, please create an issue here: https://github.com/debricked/cli/issues\n"),
string("No specific documentation for this problem yet. If you would like this message to more informative for this error, please create an issue here: https://github.com/debricked/cli/issues\n"),
jobError.Documentation(),
)
jobError.SetDocumentation("documentation")
Expand Down

0 comments on commit 78976e8

Please sign in to comment.