Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance Maven errors #162

Merged
merged 5 commits into from
Dec 12, 2023
Merged

Enhance Maven errors #162

merged 5 commits into from
Dec 12, 2023

Conversation

4ernovm
Copy link
Contributor

@4ernovm 4ernovm commented Dec 8, 2023

No description provided.

@4ernovm 4ernovm self-assigned this Dec 8, 2023
filip-debricked
filip-debricked approved these changes Dec 8, 2023
View reviewed changes
Copy link
Collaborator

@filip-debricked filip-debricked left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! I have not used maven much though, so unsure how I would like the specific errors to be documented.

internal/resolution/pm/maven/job.go Show resolved Hide resolved
internal/resolution/pm/maven/job.go Outdated Show resolved Hide resolved
internal/resolution/pm/maven/job_test.go Outdated Show resolved Hide resolved
internal/resolution/pm/maven/job.go Outdated Show resolved Hide resolved
internal/resolution/pm/maven/job.go Outdated Show resolved Hide resolved
@4ernovm 4ernovm force-pushed the maven-error-enhancements branch from 554468b to c6f48fc Compare December 11, 2023 13:30
@emilwareus emilwareus force-pushed the pip-error-enhancements branch from e70da90 to 254a8e0 Compare December 12, 2023 13:28
@emilwareus emilwareus force-pushed the maven-error-enhancements branch from c6f48fc to 6c9c512 Compare December 12, 2023 14:19
Base automatically changed from pip-error-enhancements to main December 12, 2023 14:39
@sweoggy sweoggy force-pushed the maven-error-enhancements branch from 43566d6 to d30f062 Compare December 12, 2023 15:30
@github-actions GitHub Actions
Copy link

CodeScene PR Check

View detailed results in CodeScene
Code Health Quality Gates ✅ OK
Recommended Review Level Lightweight sanity check
Declining Code Health 0 findings(s) 🚩
Improving Code Health 0 findings(s) ✅
Affected Hotspots 0 files(s) 🔥

@sweoggy sweoggy merged commit cac75d6 into main Dec 12, 2023
19 checks passed
@sweoggy sweoggy deleted the maven-error-enhancements branch December 12, 2023 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilwareus emilwareus emilwareus left review comments

@filip-debricked filip-debricked filip-debricked approved these changes

Assignees

@4ernovm 4ernovm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@4ernovm @emilwareus @filip-debricked @sweoggy