fix(vm): use generic model with explicit features for Discovery cpu type #580
+76
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diafour
force-pushed
the
fix/vm/libvirt-common-model-for-migration-between-mixed-servers
branch
2 times, most recently
from
9408e0c to
2f36d28
Compare
diafour
force-pushed
the
fix/vm/libvirt-common-model-for-migration-between-mixed-servers
branch
from
2794611 to
940453d
Compare
diafour
force-pushed
the
fix/vm/libvirt-common-model-for-migration-between-mixed-servers
branch
2 times, most recently
from
9e8c108 to
53229a3
Compare
Isteb4k
previously approved these changes
Jan 14, 2025
diafour
changed the title
diafour
force-pushed
the
fix/vm/libvirt-common-model-for-migration-between-mixed-servers
branch
from
53229a3 to
2b6f14d
Compare
- Use kvm64 model for Discovery and Features types. - Patch kubevirt to prevent node selector on VM Pos for kvm64 model. - Add internal documentation describing problems with Discovery type. Signed-off-by: Ivan Mikheykin <[email protected]>
diafour
force-pushed
the
fix/vm/libvirt-common-model-for-migration-between-mixed-servers
branch
from
2b6f14d to
8f9b0ae
Compare
Isteb4k
approved these changes
Jan 14, 2025
diafour
deleted the
fix/vm/libvirt-common-model-for-migration-between-mixed-servers
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Why do we need it, and what problem does it solve?
Discovery implemented using CPU model "host-model" with a set of features not works as expected for different nodes: libvirt resolves host-model to the specific CPU model on the node where VM launches first and use this model on target node when migrating. This "resolving" prevents migration from the node with the recent CPU model to the node with the previous CPU model.
What is the expected result?
Use nodeSelector on VM to test it.
Checklist