Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module) fix register module issue #614

Merged
merged 1 commit into from
Jan 9, 2025
Merged

Conversation

fl64
Copy link
Member

@fl64 fl64 commented Jan 6, 2025

Description

Fix register module issue

Why do we need it, and what problem does it solve?

We need to fix an issue:

register hooks search and register hooks: module hook --config invalid: get shell hook config: exit status 1

What is the expected result?

Checklist

  • The code is covered by unit tests.
  • e2e tests passed.
  • Documentation updated according to the changes.
  • Changes were tested in the Kubernetes cluster manually.

@fl64 fl64 changed the title fix(module) fix python deps fix(module) fix python hook issue Jan 6, 2025
Signed-off-by: Pavel Tishkov <[email protected]>
@fl64 fl64 force-pushed the fix/module/fix-python-deps branch from 52c30ec to 2529e3f Compare January 9, 2025 05:13
@fl64 fl64 changed the title fix(module) fix python hook issue fix(module) fix register module issue Jan 9, 2025
@fl64 fl64 requested a review from yaroslavborbat January 9, 2025 05:23
Comment on lines +123 to +131
from: {{ .Images.BASE_ALT_P11 }}
fromCacheVersion: "2024-11-07.1"
git:
- add: /lib/python/requirements.txt
to: /requirements.txt
shell:
beforeInstall:
- apt-get update
- apt-get install -y python3 python3-module-pip-run

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ALT Linux, when installing the package this way we will get version 3.12.7 of python. Is this correct?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Previously, it was necessary to use version 3.9, as far as I remember it was necessary for hooks.
I understand that this was fixed?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only remember that we needed a version greater than 3.8 ( using := )

@fl64 fl64 force-pushed the fix/module/fix-python-deps branch from 4560540 to 2529e3f Compare January 9, 2025 08:03
@fl64 fl64 merged commit f405776 into main Jan 9, 2025
23 checks passed
@fl64 fl64 deleted the fix/module/fix-python-deps branch January 9, 2025 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants