fix(vd): fix condition status updates in VirtualDisk #625
+110
−63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: dmitry.lopatin <[email protected]>
Signed-off-by: dmitry.lopatin <[email protected]>
LopatinDmitr
changed the title
Isteb4k
requested changes
Jan 14, 2025
images/virtualization-artifact/pkg/controller/vd/internal/inuse.go
Outdated
Show resolved
Hide resolved
images/virtualization-artifact/pkg/controller/vd/internal/inuse.go
Outdated
Show resolved
Hide resolved
images/virtualization-artifact/pkg/controller/vd/internal/inuse.go
Outdated
Show resolved
Hide resolved
LopatinDmitr
force-pushed
the
fix/vd/fix-condition-changes
branch
2 times, most recently
from
9ef497a to
4c55bf8
Compare
Signed-off-by: dmitry.lopatin <[email protected]>
LopatinDmitr
force-pushed
the
fix/vd/fix-condition-changes
branch
from
4c55bf8 to
4fd488c
Compare
Isteb4k
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses two issues related to the update generation in conditions for the VirtualDisk module. It fixes the update generation process and changes the status of in-use conditions from "Unknown" to "False".
Why do we need it, and what problem does it solve?
By fixing the update generation and clarifying the status of in-use conditions, this PR ensures that the system behaves predictably and accurately reflects the actual state of conditions.
What is the expected result?
After these changes, condition statuses will be updated correctly, and in-use conditions will no longer show as "Unknown".
Checklist