-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(vm): add reusable mode to use previously created virtual machines for e2e tests #641
Open
Isteb4k
wants to merge
24
commits into
main
Choose a base branch
from
test/vm/reusable-mode
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Isteb4k
force-pushed
the
test/vm/reusable-mode
branch
from
January 16, 2025 17:17
21c9031
to
b615548
Compare
Isteb4k
changed the title
test(vm): add reusable mode to previously created virtual machines fo…
test(vm): add reusable mode to use previously created virtual machines for e2e tests
Jan 16, 2025
…s for e2e tests Signed-off-by: Isteb4k <[email protected]>
Isteb4k
force-pushed
the
test/vm/reusable-mode
branch
from
January 16, 2025 21:38
b615548
to
761d876
Compare
hardcoretime
previously approved these changes
Jan 17, 2025
Signed-off-by: Isteb4k <[email protected]>
This reverts commit 08e1ad3.
Signed-off-by: Roman Sysoev <[email protected]>
hardcoretime
force-pushed
the
test/vm/reusable-mode
branch
from
January 17, 2025 16:07
25dd69b
to
c162761
Compare
hardcoretime
previously approved these changes
Jan 22, 2025
Isteb4k
force-pushed
the
test/vm/reusable-mode
branch
from
January 22, 2025 17:12
46a5f53
to
9aa146d
Compare
Signed-off-by: Isteb4k <[email protected]>
Isteb4k
force-pushed
the
test/vm/reusable-mode
branch
from
January 22, 2025 17:26
9aa146d
to
ed7f6e0
Compare
Signed-off-by: dmitry.lopatin <[email protected]>
For the tmp pvc, the owner reference was missing, which could be used to find the target pvc. However, the AdjustWorkloadNodePlacement fn relies on this. Added the owner reference for tmp pvc. Signed-off-by: Isteb4k <[email protected]>
Add patch for hotplug container-disk Signed-off-by: yaroslavborbat <[email protected]>
add hotplug VI and CVI --------- Signed-off-by: yaroslavborbat <[email protected]>
* docs: update docs for v0.15 Signed-off-by: Pavel Tishkov <[email protected]> Co-authored-by: Lada Lysenko <[email protected]> Co-authored-by: Lada Lysenko <[email protected]> Co-authored-by: Ivan Mikheykin <[email protected]>
Signed-off-by: Nikita Korolev <[email protected]>
Update CRDs Signed-off-by: Max Chervov <[email protected]> Signed-off-by: Artem Kladov <[email protected]> Signed-off-by: Artem Kladov <[email protected]> Co-authored-by: denmaloyreb <[email protected]>
The check was lost on nil. The function thinks that there is already an importer under the cdi, but it is not there yet. Signed-off-by: Isteb4k <[email protected]>
Signed-off-by: Roman Sysoev <[email protected]>
…n image uploads (#655) fix(vi, cvi): Add annotations to disable buffering for ingress used in image uploads Signed-off-by: yaroslavborbat <[email protected]>
fix expressions for restrict admission policy --------- Signed-off-by: yaroslavborbat <[email protected]>
Signed-off-by: yaroslavborbat <[email protected]> Co-authored-by: Roman Sysoev <[email protected]>
…t found (#660) do not detect vmclass specification changes if vmclass is not found Signed-off-by: yaroslavborbat <[email protected]>
…s for e2e tests Signed-off-by: Isteb4k <[email protected]>
Signed-off-by: Isteb4k <[email protected]>
This reverts commit 08e1ad3.
Signed-off-by: Roman Sysoev <[email protected]>
Signed-off-by: Isteb4k <[email protected]>
Signed-off-by: Roman Sysoev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reusable mode option
The environment variable REUSABLE used to reuse resources created previously.
By default, it retains all resources created during the e2e test after its completion (no cleanup by default in this mode).
Use the
WITH_POST_CLEANUP=yes
environment variable to clean up resources created or used during the test.When a test starts, it will reuse existing virtual machines created earlier, if they exist.
If no virtual machines were found, they will be created.
For example, run test in reusable mode:
! Only the following e2e tests are supported in REUSABLE mode. All other tests will be skipped.
PostCleanUp option
WithPostCleanUpEnv defines an environment variable used to explicitly request the deletion of created/used resources.
For example, this option is useful when combined with the
REUSABLE=yes
option,as the reusable mode does not delete created/used resources by default.
For example, run test in reusable mode with the removal of all used resources after test completion: