Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(vm): add reusable mode to use previously created virtual machines for e2e tests #641

Open
wants to merge 24 commits into
base: main
Choose a base branch
from

Conversation

Isteb4k
Copy link
Contributor

@Isteb4k Isteb4k commented Jan 16, 2025

Reusable mode option

The environment variable REUSABLE used to reuse resources created previously.
By default, it retains all resources created during the e2e test after its completion (no cleanup by default in this mode).
Use the WITH_POST_CLEANUP=yes environment variable to clean up resources created or used during the test.
When a test starts, it will reuse existing virtual machines created earlier, if they exist.
If no virtual machines were found, they will be created.

For example, run test in reusable mode:

REUSABLE=yes task run

! Only the following e2e tests are supported in REUSABLE mode. All other tests will be skipped.

  • "Virtual machine configuration"
  • "Virtual machine migration"
  • "VM connectivity"
  • "Complex test"

PostCleanUp option

WithPostCleanUpEnv defines an environment variable used to explicitly request the deletion of created/used resources.
For example, this option is useful when combined with the REUSABLE=yes option,
as the reusable mode does not delete created/used resources by default.

For example, run test in reusable mode with the removal of all used resources after test completion:

REUSABLE=yes WITH_POST_CLEANUP=yes task run

@Isteb4k Isteb4k requested a review from hardcoretime January 16, 2025 17:15
@Isteb4k Isteb4k requested a review from dmitrpopkov January 16, 2025 17:15
@Isteb4k Isteb4k marked this pull request as ready for review January 16, 2025 17:16
@Isteb4k Isteb4k force-pushed the test/vm/reusable-mode branch from 21c9031 to b615548 Compare January 16, 2025 17:17
@Isteb4k Isteb4k changed the title test(vm): add reusable mode to previously created virtual machines fo… test(vm): add reusable mode to use previously created virtual machines for e2e tests Jan 16, 2025
@Isteb4k Isteb4k force-pushed the test/vm/reusable-mode branch from b615548 to 761d876 Compare January 16, 2025 21:38
hardcoretime
hardcoretime previously approved these changes Jan 17, 2025
hardcoretime
hardcoretime previously approved these changes Jan 22, 2025
@Isteb4k Isteb4k force-pushed the test/vm/reusable-mode branch from 9aa146d to ed7f6e0 Compare January 22, 2025 17:26
LopatinDmitr and others added 9 commits January 23, 2025 18:40
For the tmp pvc, the owner reference was missing, which could be used to find the target pvc.
However, the AdjustWorkloadNodePlacement fn relies on this.
Added the owner reference for tmp pvc.

Signed-off-by: Isteb4k <[email protected]>
Add patch for hotplug container-disk

Signed-off-by: yaroslavborbat <[email protected]>
add hotplug VI and CVI
---------
Signed-off-by: yaroslavborbat <[email protected]>
* docs: update docs for v0.15
Signed-off-by: Pavel Tishkov <[email protected]>
Co-authored-by: Lada Lysenko <[email protected]>
Co-authored-by: Lada Lysenko <[email protected]>
Co-authored-by: Ivan Mikheykin <[email protected]>
Update CRDs

Signed-off-by: Max Chervov <[email protected]>
Signed-off-by: Artem Kladov <[email protected]>
Signed-off-by: Artem Kladov <[email protected]>
Co-authored-by: denmaloyreb <[email protected]>
The check was lost on nil.
The function thinks that there is already an importer under the cdi, but it is not there yet.

Signed-off-by: Isteb4k <[email protected]>
yaroslavborbat and others added 10 commits January 23, 2025 18:40
…n image uploads (#655)

fix(vi, cvi): Add annotations to disable buffering for ingress used in image uploads
Signed-off-by: yaroslavborbat <[email protected]>
fix expressions for restrict admission policy
---------
Signed-off-by: yaroslavborbat <[email protected]>
Signed-off-by: yaroslavborbat <[email protected]>
Co-authored-by: Roman Sysoev <[email protected]>
…t found (#660)

do not detect vmclass specification changes if vmclass is not found

Signed-off-by: yaroslavborbat <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants