feat(vmip): add new events #645
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Valeriy Khorunzhin <[email protected]>
eofff
force-pushed
the
feat/vmip/add-events
branch
from
6cf5250 to
8cddac6
Compare
| @@ -144,14 +144,18 @@ func (h IPLeaseHandler) createNewLease(ctx context.Context, state state.VMIPStat | |||
| Reason(vmipcondition.VirtualMachineIPAddressIsOutOfTheValidRange). | |||
| Message(fmt.Sprintf("The requested address %s is out of the valid range", | |||
| vmip.Spec.StaticIP)) | |||
| h.recorder.Event(vmip, corev1.EventTypeWarning, vmipcondition.VirtualMachineIPAddressIsOutOfTheValidRange.String(), msg) | |||
| h.recorder.Eventf(vmip, corev1.EventTypeWarning, virtv2.ReasonVMIPLeaseBoundFailed, "The requested address %s is out of the valid range", vmip.Spec.StaticIP) | |||
There was a problem hiding this comment.
we should use variable "msg" because this message is identical with text in the "Message" from line 145.
| h.recorder.Event(vmip, corev1.EventTypeWarning, vmipcondition.VirtualMachineIPAddressLeaseAlreadyExists.String(), msg) | ||
| h.recorder.Eventf( | ||
| vmip, corev1.EventTypeWarning, virtv2.ReasonVMIPLeaseBoundFailed, | ||
| "VirtualMachineIPAddressLease %s is bound to another VirtualMachineIPAddress", |
There was a problem hiding this comment.
same situation with identical message.
| // ReasonVMIPVMAttached is event reason that VMIP attached to VM | ||
| ReasonVMIPVMAttached = "VMIPVMAttached" | ||
| // ReasonVMIPVMDetached is event reason that VMIP not attached to VM | ||
| ReasonVMIPVMDetached = "VMIPVMDetached" |
There was a problem hiding this comment.
I think "NotAttached" seems better. "Detached" sounds like VMIP was attached to VM and now is detached.
Isteb4k
requested changes
Jan 22, 2025
| @@ -104,6 +111,7 @@ func (h *LifecycleHandler) Handle(ctx context.Context, state state.VMIPState) (r | |||
| vmipStatus.VirtualMachine = vm.Name | |||
| conditionAttach.Status(metav1.ConditionTrue). | |||
| Reason(vmipcondition.Attached) | |||
| h.recorder.Eventf(vmip, corev1.EventTypeNormal, virtv2.ReasonVMIPVMAttached, "VMIP is attached to %q/%q", vm.Namespace, vm.Name) | |||
There was a problem hiding this comment.
Don't use abbreviations in messages for user
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Why do we need it, and what problem does it solve?
What is the expected result?
Checklist