feat(vmsnapshot): add new events #647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hardcoretime
force-pushed
the
feat/vmsnapshot/add-new-events
branch
from
bee9d48 to
2618d97
Compare
Signed-off-by: Roman Sysoev <[email protected]>
hardcoretime
force-pushed
the
feat/vmsnapshot/add-new-events
branch
from
2618d97 to
a664fe1
Compare
Isteb4k
approved these changes
Jan 22, 2025
| @@ -61,7 +64,7 @@ func (h LifeCycleHandler) Handle(ctx context.Context, vmSnapshot *virtv2.Virtual | |||
|
|
|||
| vm, err := h.snapshotter.GetVirtualMachine(ctx, vmSnapshot.Spec.VirtualMachineName, vmSnapshot.Namespace) | |||
| if err != nil { | |||
| setPhaseConditionToFailed(cb, &vmSnapshot.Status.Phase, err) | |||
| setPhaseConditionToFailed(h, cb, vmSnapshot, err) | |||
There was a problem hiding this comment.
Maybe make the function a method? So we don't have to pass the handler as an argument.
Isteb4k
requested changes
Jan 22, 2025
| vmSnapshot, | ||
| corev1.EventTypeWarning, | ||
| virtv2.ReasonVMSnapshottingFailed, | ||
| err.Error()+".", |
There was a problem hiding this comment.
service.CapitalizeFirstLetter(err.Error()) + "."
The same as for the message below.
Signed-off-by: Roman Sysoev <[email protected]>
hardcoretime
force-pushed
the
feat/vmsnapshot/add-new-events
branch
from
d1278fe to
2ab1419
Compare
Signed-off-by: Roman Sysoev <[email protected]>
hardcoretime
force-pushed
the
feat/vmsnapshot/add-new-events
branch
from
2ab1419 to
a6299d4
Compare
Isteb4k
approved these changes
Jan 22, 2025
hardcoretime
added a commit
that referenced
this pull request
Jan 23, 2025
Signed-off-by: Roman Sysoev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add events when
VirtualMachineSnapshot:Why do we need it, and what problem does it solve?
It improves user experience in the snapshotting process of
VirtualMachine.What is the expected result?
Checklist