-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
maxusers: Update TODOs #466
Conversation
I think this is finished. It will change a bit after #463 if that goes through first. |
0df42ec
to
a085af3
Compare
Will rebase after release. |
@jholdstock Let me know your thoughts: Edit: I just remembered this is also set in the dcrwallet conf. |
This pr won't work. stakepoolcoldextkey must also be set on wallet start-up and there's no way to query/set the value afterwards. As I think this entire concept will be changed in the end it's probably not worth making this value settable through rpc commands. As for this pr and the issue, either we should make it settable also in stakepoold conf or make it a constant for now. currently max users can't exceed 10000, even if set above, so making it a constant should not have an affect on any current pools. |
If there's no good way to check that dcrwallet.conf value, I think making this settable is a bad idea. I'm going to make maxusers a constant unless there is an objection. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry this one got ignored for so long. I've read your braindumps above and I agree with the gist of it all, so lets just merge this one and look back at this once we have privacy implemented.
-make max users a configurable variable-default 10000-stakepoold start with default 10000-when starting dcrstakepool grpc commands are used to set the max on all servers and re-derive pool fees if there was a changeahh, meant to do the draft thing, adding WIP to titleThis pr took a different direction mid-stream. I now think that maxusers is an artificial ceiling and it should be removed. If my understanding is incorrect, please comment.