Skip to content

Commit

Permalink
Merge pull request #288 from c4dt/code_cleanup
Browse files Browse the repository at this point in the history
Code cleanup
  • Loading branch information
pierluca authored Sep 24, 2024
2 parents 7288f63 + 4d51a74 commit 79fc1d7
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 6 deletions.
9 changes: 5 additions & 4 deletions .github/workflows/go_test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ jobs:
runs-on: ${{matrix.platform}}
env:
LLVL: trace
coverage: ${{ matrix.platform == 'ubuntu-latest' && github.repository == 'dedis/dela' }}
steps:
- name: Check out code into the Go module directory
uses: actions/checkout@v4
Expand All @@ -30,17 +31,17 @@ jobs:
- name: Test without coverage
env:
CRY_LVL: "warn"
if: matrix.platform == 'macos-latest' || matrix.platform == 'windows-latest'
if: ${{ env.coverage == 'false' }}
run: make test

- name: Test with coverage
env:
CRY_LVL: "warn"
if: matrix.platform == 'ubuntu-latest'
if: ${{ env.coverage == 'true' }}
run: make coverage

- name: Sonarcloud scan
if: matrix.platform == 'ubuntu-latest'
if: ${{ env.coverage == 'true' }}
uses: sonarsource/sonarcloud-github-action@master
with:
args: >
Expand All @@ -53,7 +54,7 @@ jobs:
SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}

- name: Send coverage
if: matrix.platform == 'ubuntu-latest'
if: ${{ env.coverage == 'true' }}
uses: shogo82148/actions-goveralls@v1
with:
path-to-profile: profile.cov
Expand Down
4 changes: 2 additions & 2 deletions mino/mino.go
Original file line number Diff line number Diff line change
Expand Up @@ -150,8 +150,8 @@ type Sender interface {
// Receiver is an abstraction to receive messages from a stream in the context
// of a distributed RPC.
type Receiver interface {
// Recv waits for a message to send received from the stream. It returns the
// address of the original sender and the message, or a message if the
// Recv waits for a message to be received from the stream. It returns the
// address of the original sender and the message, or an error if the
// stream is closed or the context is done.
Recv(context.Context) (Address, serde.Message, error)
}
Expand Down

0 comments on commit 79fc1d7

Please sign in to comment.