For dedis #285
Merged
For dedis #285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ineiti
commented
Apr 22, 2024
ineiti
commented
- add fastsync protocol which only sends new blocks when needed
- various small fixes:
- timeouts (for mixing 10'000 ballots)
- clean up socket file so CLI can be started twice in a row
- fix comparisons/updates of block indices and transaction nonces
Use RandomFilter to select a given amount of indexes randomly. Added suggestion from @PascalinDe
Adds the fastsync as default protocol to cosipbft. Adds a 'WithBlockSync' option for the old, slow protocol. Updates all the tests.
- increased the default timeouts (tests set their own timeout) - increased maximum message size over grpc
Closed
jbsv
reviewed
May 15, 2024
| @@ -164,7 +175,7 @@ func TestService_Scenario_ViewChange_Request(t *testing.T) { | |||
| require.Equal(t, leader, nodes[0].onet.GetAddress()) | |||
|
|
|||
| // let enough time for a round to run | |||
| time.Sleep(DefaultRoundTimeout + 100*time.Millisecond) | |||
| time.Sleep(time.Second) | |||
There was a problem hiding this comment.
Isn't there a way to speed up tests ? waiting a second so often is rather slow.
There was a problem hiding this comment.
We could add a poll-wait here: check every 100ms if the desired state is reached, and quit if after 10 checks we're not there yet.
Which methods would need that?
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.