Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor files name #1767

Merged
merged 7 commits into from
Mar 2, 2024
Merged

Refactor files name #1767

merged 7 commits into from
Mar 2, 2024

Conversation

sgueissa
Copy link
Collaborator

@sgueissa sgueissa commented Feb 29, 2024

Renaming the mod.go files without touching the message package because it will need more work than just renaming the files.

@sgueissa sgueissa self-assigned this Feb 29, 2024
@CLAassistant
Copy link

CLAassistant commented Feb 29, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

Pull reviewers stats

Stats of the last 30 days for popstellar:

User Total reviews Time to review Total comments
pierluca
🥇
5
▀▀▀
2d 6h 18m
▀▀
8
▀▀▀▀
MariemBaccari
🥈
5
▀▀▀
1d 17h 15m
1
sgueissa
🥉
2
4d 21h 28m
▀▀▀▀
8
▀▀▀▀
jbsv
2
1d 7h 33m
0
arnauds5
1
6h 55m
0
osm-alt
1
5h 52m
0
ljankoschek
1
20h 9m
0
K1li4nL
1
18m
0
emonnin-epfl
1
6h 45m
1

Copy link

sonarqubecloud bot commented Mar 2, 2024

Quality Gate Passed Quality Gate passed for 'PoP - PoPCHA-Web-Client'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

sonarqubecloud bot commented Mar 2, 2024

Quality Gate Passed Quality Gate passed for 'PoP - Be2-Scala'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

sonarqubecloud bot commented Mar 2, 2024

Copy link

sonarqubecloud bot commented Mar 2, 2024

Quality Gate Passed Quality Gate passed for 'PoP - Fe2-Android'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

sonarqubecloud bot commented Mar 2, 2024

Quality Gate Passed Quality Gate passed for 'PoP - Fe1-Web'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@sgueissa sgueissa marked this pull request as ready for review March 2, 2024 09:49
@sgueissa sgueissa requested a review from a team as a code owner March 2, 2024 09:49
Copy link
Contributor

@emonnin-epfl emonnin-epfl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@MariemBaccari MariemBaccari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can see some changes inside files but I assume it's because of some automatic IDE formatting issue. Assuming you just renamed the file, the PR looks good to me, good job!

@sgueissa sgueissa merged commit 7a29930 into master Mar 2, 2024
18 checks passed
@sgueissa sgueissa deleted the work-be1-stuart-refactor-file-names branch March 2, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants