Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ElectionResultQuestion message data validation #1769

Merged
merged 4 commits into from
Mar 4, 2024

Conversation

Kaz-ookid
Copy link
Contributor

addressing #1751

Validated and tested validations for ElectionResultQuestion and QuestionResult.

@Kaz-ookid Kaz-ookid requested a review from quadcopterman March 3, 2024 14:44
@Kaz-ookid Kaz-ookid self-assigned this Mar 3, 2024
@Kaz-ookid Kaz-ookid requested a review from a team as a code owner March 3, 2024 14:44
Copy link

github-actions bot commented Mar 3, 2024

Pull reviewers stats

Stats of the last 30 days for popstellar:

User Total reviews Time to review Total comments
MariemBaccari
🥇
6
▀▀▀
2d 11m
1
pierluca
🥈
5
▀▀
2d 6h 18m
▀▀
8
▀▀▀▀
sgueissa
🥉
2
4d 21h 28m
▀▀▀
8
▀▀▀▀
emonnin-epfl
2
7h 27m
1
jbsv
2
1d 7h 33m
0
Tyratox
1
2d 4h 54m
▀▀
0
arnauds5
1
6h 55m
0
osm-alt
1
5h 52m
0
ljankoschek
1
20h 9m
0
K1li4nL
1
18m
0

Copy link

sonarqubecloud bot commented Mar 3, 2024

Quality Gate Passed Quality Gate passed for 'PoP - PoPCHA-Web-Client'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

sonarqubecloud bot commented Mar 3, 2024

Quality Gate Passed Quality Gate passed for 'PoP - Be1-Go'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

sonarqubecloud bot commented Mar 3, 2024

Quality Gate Passed Quality Gate passed for 'PoP - Be2-Scala'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

sonarqubecloud bot commented Mar 3, 2024

Copy link

sonarqubecloud bot commented Mar 3, 2024

Quality Gate Passed Quality Gate passed for 'PoP - Fe1-Web'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Contributor

@matteosz matteosz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Kaz-ookid Kaz-ookid merged commit cc80711 into master Mar 4, 2024
19 checks passed
@Kaz-ookid Kaz-ookid deleted the work-fe2-maxime-electionresultquestion-validation branch March 4, 2024 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants